Skip to content

1187 task investigate all site warnings in the console tab#1320

Merged
JackyFTW merged 37 commits intodevfrom
1187-task-investigate-all-site-warnings-in-the-console-tab
Apr 7, 2026
Merged

1187 task investigate all site warnings in the console tab#1320
JackyFTW merged 37 commits intodevfrom
1187-task-investigate-all-site-warnings-in-the-console-tab

Conversation

@wlh3903
Copy link
Copy Markdown

@wlh3903 wlh3903 commented Feb 24, 2026

  • Cleaned up all console.logs
  • Fixed most console error messages (ones involving redux reworks left i.e., Lab 2 exercise)
  • No discrepancies across browsers (ex: chrome vs safari)
  • Accessibility functions
  • Pages can scale without distorting page
  • No dead links
  • Navbar is consistent across the site
  • Pages are screen-reader accessible
  • Contrast meets standards for accessibility
  • Pages are keyboard accessible
  • Code is cleaned up and bug-free (ex: debug statements removed)

@wlh3903 wlh3903 requested review from JackyFTW and ejt7508 February 24, 2026 16:58
@wlh3903 wlh3903 self-assigned this Feb 24, 2026
@wlh3903 wlh3903 linked an issue Feb 24, 2026 that may be closed by this pull request
3 tasks
Copy link
Copy Markdown
Contributor

@shmowen shmowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple things:

  1. Got some merge conflicts that need fixing
  2. Opening the labs to the About section shows off this warning in console:
Image

Not totally sure if this is within the scope of this story, might be a CRA error.

Copy link
Copy Markdown
Member

@JackyFTW JackyFTW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still seems like there's a good amount of site warnings! Make sure to investigate each lab's exercises. I have provided a handful below to get started (Labs 1-5)

Comment thread client/src/components/exercise/lab1/components/Repair.js
Comment thread client/src/components/exercise/lab1/components/Repair.js
Comment thread client/src/components/exercise/lab2/components/exercise.js
Comment thread client/src/assets/stylesheets/components/css/colorPicker.css
Comment thread client/src/assets/stylesheets/components/css/colorPicker.css
Comment thread client/src/assets/stylesheets/components/css/colorPicker.css
Comment thread client/src/assets/stylesheets/components/css/colorPicker.css
Comment thread client/src/assets/stylesheets/components/css/colorPicker.css
Copy link
Copy Markdown
Contributor

@shmowen shmowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through every lab and route, and here are my notes:

  • Remove all console.log statements (4) from UserUpdatedExercise.js (Lab 3)

  • The following error shows up when entering Lab 8 Reading

Image

Comment thread client/src/components/exercise/lab2/Main.js Outdated
Comment thread client/src/components/exercise/lab2/Main.js
Copy link
Copy Markdown
Contributor

@shmowen shmowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strong work warner!

Copy link
Copy Markdown
Member

@JackyFTW JackyFTW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Copy Markdown
Member

@JackyFTW JackyFTW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-approved afer merge conflict fix

Copy link
Copy Markdown
Contributor

@shmowen shmowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JackyFTW JackyFTW merged commit a053b61 into dev Apr 7, 2026
3 checks passed
@JackyFTW JackyFTW deleted the 1187-task-investigate-all-site-warnings-in-the-console-tab branch April 7, 2026 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Task: Investigate all site warnings in the console tab

3 participants